fastai / nbdev

Create delightful software with Jupyter Notebooks
https://nbdev.fast.ai/
Apache License 2.0
4.9k stars 487 forks source link

No sidebar on Safari with `nbdev_new` of a blank project #1349

Closed dsm-72 closed 1 year ago

dsm-72 commented 1 year ago

Provide a minimally reproducible example

# git clone empty repo
$ cd empty-repo
$ nbdev_new

# update workflows to use python 3.10

$ git add .
$ git commit -m 'add everything and then update workflows for python 3.10'

$ cp nb/00_core.ipynb nb/01_another.ipynb
# update another to be a different module

$ nbdev_prepare
$ git add .; git commit -m 'add another module'; git push origin main

# update GitHub repo to allow actions to write
# update GitHub repo to use pages
dsm-72 commented 1 year ago

additionally it would be nice to know the following:

deven-gqc commented 1 year ago

Can you run nbdev_prepare and the push all the files as well? I see that the sidebar.yml file is missing.

dsm-72 commented 1 year ago

@deven-gqc I already did before pushing. I just did again, though.

deven-gqc commented 1 year ago

Ah, I see. Either you should run nbdev_sidebar or nbdev_preview which generates the sidebar.yml file for you, And then you need to push that as well.

dsm-72 commented 1 year ago

@deven-gqc

$ nbdev_sidebar
$ git add .; git commit -m 'add sidebar'; git push'
# wait on github actions

no sidebar

$ nbdev_preview
# opens up safari and I see two sidebars and a header
# ctrl-c
$ git status
# no changes to commit

no sidebar

$ nbdev_prepare
$ git status
# no changes to commit

no sidebar

dsm-72 commented 1 year ago

@deven-gqc Any ideas?

deven-gqc commented 1 year ago

Works for me! https://deven-gqc.github.io/nbdev-new-no-sidebar/ Can you go in settings and make sure you are deploying from a branch? image

dsm-72 commented 1 year ago

@deven-gqc I was already deploying form a branch Screenshot 2023-06-07 at 11 55 30 AM

deven-gqc commented 1 year ago

Can you please check your settings insides Pages tab in the sidebar? The setting in the General tab refers to the default branch, it does not have anything to do with GitHub Pages.

dsm-72 commented 1 year ago

@deven-gqc I see where I misclicked >.<

deven-gqc commented 1 year ago

No worries!