Closed deven367 closed 8 months ago
Message ID: @.***>Thanks for looking into this. I guess the best thing to do is to just find the bit of the repr that it consistent, and have the test confirm that is correct.
I think even that won't be possible. They've changed the entire docstring and they've even added a new arg (boundary=None
) to the Enum class.
# new in 3.11
e (value, names=None, module=None, qualname=None, type=None, start=1, boundary=None)
Create a collection of name/value pairs.
# in previous versions
e (value, names=None, module=None, qualname=None, type=None, start=1)
An enumeration.
Message ID: @.***>OK maybe just get rid of that test then...
Will do!
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@jph00 It's ready for review.
Thank you!
hello, I'm trying to add support for py3.11 for
nbdev
, I'm trying some stuff on my fork. The PR will also eventually close #1372.I had a question for @jph00, there's only one test case which fails for 3.11 which is in
showdoc
. This has only come into existence because the docstring for the Enum was changed in 3.11. How should I try to handle the test case in such a situation? The test case is listed below,