search

fastai / nbdev

Create delightful software with Jupyter Notebooks
https://nbdev.fast.ai/
Apache License 2.0
4.8k stars 484 forks source link

fixes #1405 #1406

Closed deven367 closed 2 months ago

deven367 commented 2 months ago

This PR fixes the broken link in the jupyter-git blog.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

deven367 commented 2 months ago

Hi @jph00, I'm not sure why runners are failing, I think GH has internally removed the Intel-based runners for macos? I may be wrong? Any thoughts?

jph00 commented 2 months ago

Ah looks like 3.7 isn't supported any more. I just removed it. Can you merge in my change from master?

deven367 commented 2 months ago

@jph00 I just merged from the master.

In a different PR, should I also remove 3.7 from the py_versions? https://github.com/fastai/nbdev/blob/153f2f6a6b55a29b295affbf8d9dd9844d66a169/setup.py#L29

jph00 commented 2 months ago

Many thanks. I don't think we need to update setup.py since the lib still works fine -- it's just not in CI.