Closed igorbrigadir closed 3 years ago
Unfortunately the fix in #391 does not solve it in 1.1.12
either.
When using a glob like "*_test.ipynb" it does not execute the notebooks, just skips to "All tests are passing!"
I'm not sure what you are doing wrong, is it because you aren't passing in the proper directory? from the root of this repo:
nbdev_test_nbs --fname nbs/*_test.ipynb
testing /Users/hamelsmu/github/nbdev/nbs/04_test.ipynb
All tests are passing!
@igorbrigadir I also tested your repo and it works just fine
gh repo clone igorbrigadir/nbdev-api-template
cd nbdev-api-template
Followed by
nbdev_test_nbs --fname test_*
testing /Users/hamelsmu/github/nbdev-api-template/test_nbdev.ipynb
...
Closing this issue. However, happy to repoen if you can provide a reproduceable example, with a link to a repo with files. Thanks!
My only guess is you aren't using the latest version of nbdev. You must clone this repo and do pip install -e .
from the root. There might have not been a release yet with yesterday's PR.
Thanks so much for checking!
My only guess is you aren't using the latest version of nbdev. You must clone this repo and do pip install -e . from the root. There might have not been a release yet with yesterday's PR.
Yes, that was exactly my mistake - i used pip install --upgrade git+https://github.com/fastai/nbdev.git
but that didn't actually replace the existing one i had, installing the latest master version resolves this issue.
It all works now! Thanks!
You used to be able to use a wildcard / glob in
--fname
parameter innbdev_test_nbs
but this seems to be broken in 1.1.7In 1.1.6:
nbdev_test_nbs --fname "test_*"
this works.
With 1.1.7
nbdev_test_nbs --fname "test_*"
with a later version on pypi: 1.1.8:
With the latest pypi version, 1.1.11:
All tests are passing!
But this is wrong, because it doesn't even attempt to run the notebooks.