search

fastai / nbprocess-old

Process and export Jupyter Notebooks fast (Jupyter not required)
https://nbprocess.fast.ai/
Apache License 2.0
52 stars 12 forks source link

Change the minimal python version #76

Closed muellerzr closed 2 years ago

muellerzr commented 2 years ago

I was trying to toy around with the base behavior of nbprocess in Google Colab, and I noticed it was fighting with me on errors related to ast. Knowing previous headaches I had with nbagile and ast, I decided to check on what versions of python break nbprocess. Currently the nbprocess CI runs py 3.10, but the minimum python is set to 3.6.

I quickly tested the CI (seen here: https://github.com/muellerzr/nbprocess/runs/6973925190?check_suite_focus=true) and found that the minimal python version should be python 3.8 for nbprocess.

image

Which also then means that colab support is dropped, since that uses python 3.7.

I can try to dig into just what exactly isn't py 3.7 compatible besides the syntax error, and it is extremely likely that much of the ast usage will be included in that.

For now this pins the python version to 3.8, the minimal working version. @jph00 or @hamelsmu let me know if you want to still support py 3.7, though losing all the colab folks would be quite sad!

jph00 commented 2 years ago

Message ID: @.***>We definitely want to support py37, so we shouldn't merge this.

Thanks for the detective work!

muellerzr commented 2 years ago

Np! Looking into this now, will open a PR if it seems easy enough, otherwise will drop in what I found here @jph00