search

fastai / nbprocess-old

Process and export Jupyter Notebooks fast (Jupyter not required)
https://nbprocess.fast.ai/
Apache License 2.0
52 stars 12 forks source link

test `showdoc` edge cases & ignore `typedispatch` #88

Closed hamelsmu closed 2 years ago

hamelsmu commented 2 years ago

This PR does two things:

  1. Adds tests for showdoc edgecases I found in nbdev, the rest of the edge cases I display in the notebook itself.
  2. I noticed that we are currently ignoring typedispatch in for showdoc in nbdev v1. We should discuss how we want to display typed dispatch in the docs as that is an interesting use case. For right now, I will ignore typedispatch so the docs won't break when you try to convert to nbprocess.

Note: I had already addressed other edge cases in previous PRs

cc: @jph00 @muellerzr

This closes #62

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jph00 commented 2 years ago

Thanks @hamelsmu ! Before we decide on typedispatch in nbdev, we need to decide if we're replacing it with plum...