Add Docments to tabular.data

fastaidocsprint / fastai

Documentation Sprint for the fastai deep learning library

http://fastaidocsprint.github.io/fastai

Apache License 2.0

15 stars 17 forks source link

Add Docments to tabular.data #60

Closed Karthik-d-k closed 2 years ago

Karthik-d-k commented 2 years ago

This is a simple PR to add Docments to notebook -> 41_tabular.data. I tried my best to align with the style guide provided. Happy to do some modifications if there are any corrections.

Notes :-

For input rm_type_tfms in test_dl method -> I'm not completely sure if i did justification, my understanding might be wrong here though, looking forward to learn things in my first PR towards open source 😄

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Karthik-d-k commented 2 years ago

Thanks! Added some nits, please fix 😄

Thank you very much 😃 I have fixed all the suggestions/corrections provided by both of you (@muellerzr , @kevinbird15 )

Only thing I'm not sure about is the following comment -->

csv:(str,Path,io.BufferedReader), # A csv from which features/targets are inferred

Please let me know if i missed something, i will fix it 🚀

Karthik-d-k commented 2 years ago

Accidentally closed the PR 😭

muellerzr commented 2 years ago

Great work!

Karthik-d-k commented 2 years ago

Great work!

Thank you very much for the opportunity, and also thanks for all the support without which i wouldn't be able to contribute my first open source contribution 😄 🚀 Looking forward for many more contributions in future..!