fastaidocsprint / fastai

Documentation Sprint for the fastai deep learning library
http://fastaidocsprint.github.io/fastai
Apache License 2.0
15 stars 17 forks source link

Add docments for 42_tabular.model #79

Closed michaelnimmer closed 2 years ago

michaelnimmer commented 2 years ago

I added docments for the functions in this notebook. I also edited the docstring for the get_emb_sz function.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

michaelnimmer commented 2 years ago

I made the requested changes. I went with Kevin's suggestions where they differed from Zach's. Please let me know if anything else needs to be changed. Thank you both for your feedback!

michaelnimmer commented 2 years ago

One very small nit then I approve 😄 Great work

Fixed.