Closed michaelnimmer closed 2 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
I made the requested changes. I went with Kevin's suggestions where they differed from Zach's. Please let me know if anything else needs to be changed. Thank you both for your feedback!
One very small nit then I approve 😄 Great work
Fixed.
I added docments for the functions in this notebook. I also edited the docstring for the
get_emb_sz
function.