search

fastaidocsprint / fastai

Documentation Sprint for the fastai deep learning library
http://fastaidocsprint.github.io/fastai
Apache License 2.0
15 stars 16 forks source link

documents 08_vision.data: TransformBlocks for vision #88

Closed ChrisRichardMiles closed 2 years ago

ChrisRichardMiles commented 2 years ago

The only issue is that I changed an argument from cls to clss. The problem is that show_doc does not show the "cls" argument. You can see that in the _format_args function [here]https://github.com/fastai/nbdev/blob/master/nbdev/showdoc.py#L347. I know we aren't supposed to touch any code, but I'm not sure what to do here.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

muellerzr commented 2 years ago

@ChrisRichardMiles please change this back to cls. We'll be addressing the cls issue in nbdev

warner-benjamin commented 2 years ago

@ChrisRichardMiles the changes need to be added to the 08_vision.data.ipynb notebook and the unchanged notebooks reverted.

ChrisRichardMiles commented 2 years ago

@ChrisRichardMiles the changes need to be added to the 08_vision.data.ipynb notebook and the unchanged notebooks reverted.

Ok I will do it first thing in the morning. Thanks for the help

ChrisRichardMiles commented 2 years ago

@warner-benjamin @marii-moe I have made the suggested changes and reverted the notebooks that should not have been touched. I still have an annoying local error message that I haven't been able to fix yet. I will fix it as soon as I can (hopefully tonight) and then I will request reviews.

ChrisRichardMiles commented 2 years ago

@ChrisRichardMiles Assuming the"UserWarning: floordiv is deprecated" is what you are referring to, it was already checked into the codebase, so you don't need to worry about it. There is an issue open for it #3588.

LGTM. Thanks!

No, I actually meant an error that I also had in my last PR. But looking again, I realize I misread the file changes, because that part is highlighted in red, so it seems it was deleted. I am still confused to see it at all, but I guess everything is ok, so I'm going to request the review of @marii-moe