fastalgorithms / fmm3dbie

GNU General Public License v2.0
25 stars 10 forks source link

Fix MATLAB tests #12

Closed ludvigak closed 3 months ago

ludvigak commented 3 months ago

Simple fixes to get rid of errors in Matlab test suite

NOTE: There are more hard-coded paths in demo/ that point to ~/git/fmm3dbie and ~/git/surface-hps

ludvigak commented 3 months ago

To test the branch you'll have to run git submodule update --init --recursive to get the new submodule checked out

ahbarnett commented 3 months ago

grepping matlab directory I only see chebpts and barymat used from chebfun pkg - if that's all, can't we remove chebfun as a dependency?

ludvigak commented 3 months ago

First I tried copying in only legpts and chebpts, but the latter called chebtech1, at which point I gave up and pulled in all of chebfun. You can probably untangle the dependencies with some patience though.

mrachh commented 3 months ago

We are on it to remove those dependencies. Thanks for these catches Ludvig, we can merge them in, once the dependencies are removed.

ahbarnett commented 3 months ago

I forgot legpts. Yes, keep chebfun as dependency for next week.

mrachh commented 3 months ago

Hi Ludvig, can you remove the chebfun dependency and update the pull request? I think I should've successfully removed those dependencies..

ludvigak commented 3 months ago

Had to do a few fixes, but now all tests pass without Chebfun