search

fastalgorithms / fmm3dbie

GNU General Public License v2.0
25 stars 10 forks source link

Matlab wrappers: can't get going. suggest remove all addpaths from test files #5

Closed ahbarnett closed 3 months ago

ahbarnett commented 7 months ago

https://github.com/fastalgorithms/fmm3dbie/blob/d170dd287dfe81e8aa181b9c81914c760426b067/matlab/test/test_surf_lap.m#L1

THis is an example of a machine-specific addpath that should be removed (what user has the folder ~/git/... ?) Instead have an overall global setup.m command for the repo, that does any addpaths. A good example is https://github.com/danfortunato/fully-adaptive-poisson/blob/master/setup.m It sets paths, reports if prereqs not found.

Then remove addpath from all test and demo files. The user should have run setup first.

I'm also having trouble since the demos and many tests seem to require surface-hps, not listed as a prereq for the repo.

Thanks and keep up great work! Alex

ahbarnett commented 3 months ago

seems to be resolved, closing