fastapi-users / fastapi-users-db-beanie

FastAPI Users database adapter for Beanie
MIT License
5 stars 5 forks source link

Replace get_event_loop with single methods in conftest #4

Closed vittoriozamboni closed 2 years ago

vittoriozamboni commented 2 years ago

Removes the warning in Python 3.10 caused by get_event_loop when a current loop is not present. See also this discussion

tests_warning

After the patch, no warning is raised and all tests pass.

tests_no_warnings

codecov[bot] commented 2 years ago

Codecov Report

Merging #4 (bd17247) into main (9ca6d87) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   64.35%   64.35%           
=======================================
  Files           2        2           
  Lines         101      101           
=======================================
  Hits           65       65           
  Misses         36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ca6d87...bd17247. Read the comment docs.

frankie567 commented 2 years ago

Yes, that's something I gradually update in my projects :) Thank you for catching it!