search

fastapi / typer

Typer, build great CLIs. Easy to code. Based on Python type hints.
https://typer.tiangolo.com/
MIT License
15.66k stars 666 forks source link

🐛 Ensure that `Optional[list]` values work correctly with callbacks #1018

Open solesensei opened 2 weeks ago

solesensei commented 2 weeks ago

This pull request refactors the generate_list_convertor function to handle the case when the value parameter is None.

Fixes: https://github.com/fastapi/typer/discussions/762

github-actions[bot] commented 2 weeks ago

📝 Docs preview for commit 5c9ba8fdb7f4d50046ba119a453845da24b974d0 at: https://d5834c3f.typertiangolo.pages.dev

github-actions[bot] commented 2 weeks ago

📝 Docs preview for commit ade45175a2d2af3c64002cd47369d143fd953b94 at: https://3a35550f.typertiangolo.pages.dev

solesensei commented 1 week ago

@tiangolo, Hi! Please check this review. It blocks our application from upgrading to 0.10.0+.

solesensei commented 1 week ago

cc: @svlandeg

svlandeg commented 5 days ago

Hi @solesensei, thanks for the PR! We've got this on our internal queue and will let you know once we've been able to review it 🙏