image -> audio; ''' -> " in docstrings

fastaudio / fastai2_audio

[DEPRECATED] Audio Module for fastai v2

Apache License 2.0

65 stars 15 forks source link

image -> audio; ''' -> " in docstrings #33

Closed kdorichev closed 4 years ago

review-notebook-app[bot] commented 4 years ago

Check out this pull request on

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

scart97 commented 4 years ago

Any reason to change the docstrings from ''' to " ? Otherwise this PR is good to merge, Thanks!

kdorichev commented 4 years ago

Any reason to change the docstrings from ''' to " ?

Main reason is uniformity -- using the same style in the code.

Besides, this is what fastai developers use across their code. Since we intend to finally merge, it might be a good idea to accept their style of code, see Jeremy’s notes on fastai coding style.

kdorichev commented 4 years ago

Sorry for mixing two different changes into one PR. I will stick to the recommendation "one change -- one PR"-- from now on.