search

fastaudio / fastai2_audio

[DEPRECATED] Audio Module for fastai v2
Apache License 2.0
65 stars 15 forks source link

Add a CI badge into README #35

Closed kdorichev closed 4 years ago

kdorichev commented 4 years ago

CI passing

scart97 commented 4 years ago

Does PRE_README.md have any special meaning in github? We probably want to put this badge on the top of README.md, which is generated from the index.ipynb file present on the nbs/ folder after you run nbdev_build_docs.

kdorichev commented 4 years ago

Does PRE_README.md have any special meaning in github?

No special meaning on Github that i am aware of.

We probably want to put this badge on the top of README.md, which is generated from the index.ipynb file present on the nbs/ folder after you run nbdev_build_docs.

That's exactly what make_readme() from nbdev does -- adds the contents of PRE_README.md, if present, on top of README.md. See nbdev repo's README.md for the outcome.

mogwai commented 4 years ago

Looks fine to me