Fix remove silence bug when using remove_type of "all"

fastaudio / fastai_audio

[DEPRECATED] 🔊️ Audio with fastaiv1

MIT License

160 stars 49 forks source link

Fix remove silence bug when using remove_type of "all" #26

Closed kevinbird15 closed 5 years ago

kevinbird15 commented 5 years ago

This code change fixes a bug that made remove silence create an audio clip longer than the original clip. The problem was that for each individual clip created by split, 2*padding was added which is fine when those clips remain independent as is the case with "split", but with "all" the clips are combined and the overlap causes up to a padding length delay to be added for each split.

Fixes: https://github.com/mogwai/fastai_audio/issues/25

kevinbird15 commented 5 years ago

@rbracco has proposed a different probably better way to handle this fix.

rbracco commented 5 years ago

Closing this PR as the solution I proposed is in testing for a separate PR.