search

fastbreak91 / openholdembot

Automatically exported from code.google.com/p/openholdembot
Other
0 stars 0 forks source link

CIteratorThread needs some refactoring #86

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
http://www.maxinmontreal.com/forums/viewtopic.php?f=156&t=9818

Some loop-counters are not local (i and nit),

strange exits from the loop:

if (opp_pokval>pl_pokval)
{
    pParent->_los++;
    i = nopp+999;
}

and comparisions outside
if (i!=nopp+1000)
{

That look like bad code and should be refactored in the future

Original issue reported on code.google.com by thehighfish@googlemail.com on 23 Dec 2009 at 7:12

GoogleCodeExporter commented 9 years ago 
Bad code, but it works and we have more important problems.
Won't fix for the near future

Original comment by thehighfish@googlemail.com on 2 Apr 2010 at 7:57