search

faster-cpython / bench_runner

Code for running pyperformance benchmarks on Github Action runners
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

gh-225: Raise a more helpful error in `get_runners` when there are no runners #226

Closed mpage closed 1 week ago

mpage commented 1 week ago

There may be no runners when bench_runner install is executed for the first time.

Fixes gh-225.

mpage commented 1 week ago

It's not going to create anything sensible without runners defined, however. I think I'd prefer it if this raised a helpful error instead, such as:

No runners are defined in `runners.ini`.  Please set up some runners first.

Sounds good! We should also probably make it clear in the install instructions that you should add a runner first, otherwise the first attempt at bench_runner install will raise this error.

mdboom commented 1 week ago

Sounds good! We should also probably make it clear in the install instructions that you should add a runner first, otherwise the first attempt at bench_runner install will raise this error.

Agreed. Thanks!