search

fasterthanlime / jsmad

:saxophone: Javascript MPEG-1 Audio Layer III (mp3) and ID3v2 decoder
http://audiocogs.org/codecs/mp3/
762 stars 41 forks source link

get rid of subarray calls, added testcases #2

Closed georgi closed 13 years ago

georgi commented 13 years ago

changed subarray calls to calls with array offset. added testcase for fasdct, imdct_l, imdct_s

imdct_s had a serious bug. the array indexing wasn accounting the 2dimensional structure of imdct_s.

georgi commented 13 years ago

but still the pcm output sounds like crap :(

georgi commented 13 years ago

for the sake of portability we should hide the array construction beneath a function, that decides at runtime, which implementation to be used (js array, typed-array).

nddrylliog commented 13 years ago

So, what is next? scalefactors? reorder? freqinver? alias_reduce? On Jun 2, 2011 4:00 AM, "georgi" < reply@reply.github.com> wrote:

changed subarray calls to calls with array offset. added testcase for fasdct, imdct_l, imdct_s

imdct_s had a serious bug. the array indexing wasn accounting the 2dimensional structure of imdct_s.

Reply to this email directly or view it on GitHub: https://github.com/nddrylliog/jsmad/pull/2

georgi commented 13 years ago

I'm looking at scalefactors now.