fastfetch-cli / fastfetch

An actively maintained, feature-rich and performance oriented, neofetch like system information tool.
MIT License
10k stars 398 forks source link

Wrong Icon theme output #198

Closed DarNCelsius closed 2 years ago

DarNCelsius commented 2 years ago

General description of bug:

It seems stuck on Papirus-Dark regardless of DE or WM. It's set to Qogir-dark in LXAppearance, XFCE and Cinnamon as the screenshot shows. I don't remember Plasma offhand.

multibug

Often helpful questions:

Output of fastfetch --version:

fastfetch 1.5.6-20

Output of fastfetch --load-config devinfo:

╰─ fastfetch --load-config devinfo
██████████████████  ████████    darn@manjaro
██████████████████  ████████    ------------
██████████████████  ████████    OS: Manjaro Linux [x86_64]
██████████████████  ████████    Host: X570 AORUS MASTER -CF
████████            ████████    Kernel: 5.18.12-3-MANJARO
████████  ████████  ████████    Uptime: 2 hours, 3 mins
████████  ████████  ████████    Packages: 1791 (pacman)[stable]
████████  ████████  ████████    Shell: zsh 5.9
████████  ████████  ████████    Resolution 1: 2560x1440 @ 240Hz
████████  ████████  ████████    Resolution 2: 2560x1440 @ 60Hz
████████  ████████  ████████    Resolution 3: 2560x1440 @ 120Hz
████████  ████████  ████████    DE: Cinnamon 5.4.2
████████  ████████  ████████    WM: Mutter (X11)
████████  ████████  ████████    WM Theme: Matcha-dark-azul
                                Theme: Matcha-dark-azul [GTK2/3/4]
                                Icons: Papirus-Dark [GTK2/3/4]
                                Font: DejaVu Sans (9pt) [GTK2/3/4]
                                Cursor: breeze (24px)
                                Terminal: alacritty
                                Terminal Font: Droid Sans Mono
                                CPU: AMD Ryzen 7 3800X (16) @ 4.56GHz
                                GPU: AMD ATI Radeon RX 6800/6800 XT / 6900 XT
                                Memory: 4930MiB / 15919MiB (30%)
                                Disk (/): 42GiB / 68GiB (61%)
                                Disk (/home): 136GiB / 177GiB (76%)
                                Battery: /sys/class/power_supply/ doesn't contain any battery folder
                                Locale: en_US.UTF-8

                                ████████████████████████
                                ████████████████████████

Output of fastfetch --load-config devinfo-verbose:

╰─ fastfetch --load-config devinfo-verbose
██████████████████  ████████    darn@manjaro
██████████████████  ████████    ------------
██████████████████  ████████    OS: System: Linux; Name: Manjaro Linux; Pretty name: Manjaro Linux; ID: manjaro; ID like: arch; Variant: ; Variant ID: ; Version: ; Version ID: ; Version codename: ; Build ID: rolling; Architecture: x86_64
██████████████████  ████████    Host: Family: "product_family: X570 MB; product_name: X570 AORUS MASTER; product_version: -CF; product_sku: ; bios_date: 10/13/2021; bios_release: 5.17; bios_vendor: American Megatrends International, LLC.; bios_version: F35e; board_name: X570 AORUS MASTER; board_vendor: Gigabyte Technology Co., Ltd.; board_version: ; chassis_type: 3; chassis_vendor: ; chassis_version: ; sys_vendor: Gigabyte Technology Co., Ltd.
████████  ████████  ████████    Kernel: Sysname: Linux; Release: 5.18.12-3-MANJARO; Version: #1 SMP PREEMPT_DYNAMIC Sun Jul 17 14:33:15 UTC 2022
████████  ████████  ████████    Uptime: Days: 0; Hours: 2; Minutes: 4; Seconds: 49
████████  ████████  ████████    Processes: Count: 1721
████████  ████████  ████████    Packages: All: 1791; pacman: 1791; pacman branch: stable; dpkg: 0; rpm: 0; emerge: 0; xbps: 0; flatpak: 0; snap: 0
████████  ████████  ████████    Shell: Process name: zsh; Process path: /usr/bin/zsh; Process exe: zsh; Process version: 5.9; User path: /usr/bin/zsh; User exe: zsh; User version: 5.9
████████  ████████  ████████    Resolution 1: Width: 2560; Height: 1440; Refresh rate: 240
████████  ████████  ████████    Resolution 2: Width: 2560; Height: 1440; Refresh rate: 60
████████  ████████  ████████    Resolution 3: Width: 2560; Height: 1440; Refresh rate: 120
████████  ████████  ████████    DE: Process name: cinnamon; Pretty name: Cinnamon; Version: 5.4.2
                                WM: Process name: Mutter; Pretty name: Mutter; Protocol: X11
                                WM Theme: Name: Matcha-dark-azul
                                Theme: Plasma: ; Plasma colors: ; Plasma colors pretty: ; GTK2: Matcha-dark-azul; GTK3: Matcha-dark-azul; GTK4: Matcha-dark-azul; GTK: Matcha-dark-azul [GTK2/3/4]
                                Icons: Plasma: ; GTK2: Papirus-Dark; GTK3: Papirus-Dark; GTK4: Papirus-Dark; GTK: Papirus-Dark [GTK2/3/4]
                                Font: Plasma raw: ; Plasma name: ; Plasma size: ; Plasma styles: ; Plasma pretty: ; GTK2 raw: DejaVu Sans,  9; GTK2 name: DejaVu Sans; GTK2 size: 9; GTK2 styles: ; GTK2 pretty: DejaVu Sans (9pt); GTK3 raw: DejaVu Sans,  9; GTK3 name: DejaVu Sans; GTK3 size: 9; GTK3 styles: ; GTK3 pretty: DejaVu Sans (9pt); GTK4 raw: DejaVu Sans,  9; GTK4 name: DejaVu Sans; GTK4 size: 9; GTK4 styles: ; GTK4 pretty: DejaVu Sans (9pt); GTK: DejaVu Sans (9pt) [GTK2/3/4]
                                Cursor: Theme: breeze; Size: 24
                                Terminal: Process: alacritty; Path: alacritty; Exe: alacritty
                                Terminal Font: Raw: Droid Sans Mono; Name: Droid Sans Mono; Size: 10.0; Styles: ; Pretty: Droid Sans Mono
                                CPU: Name: AMD Ryzen 7 3800X 8-Core Processor; Pretty: AMD Ryzen 7 3800X; Vendor: AuthenticAMD; Logical online: 16; Logical configured: 16; Physical: 8; Cores: 16; temperature: 40.5; bios: 0; scaling max: 4.56; scaling min: 0.55; info max: 4.56; info min: 0.5; cpuinfo: 0.55; frequency: 4.56
                                GPU: Vendor: Advanced Micro Devices, Inc. [AMD/ATI]; Vendor pretty: AMD ATI; Name: Navi 21 [Radeon RX 6800/6800 XT / 6900 XT]; Name pretty: Radeon RX 6800/6800 XT / 6900 XT; Driver: amdgpu; Temperature: 34
                                Memory: Used: 4943; Total: 15919; Percentage: 31
                                Disk (/): Used: 42; Total: 68; Files: 1166462; Percentage: 61
                                Disk (/home): Used: 136; Total: 177; Files: 375784; Percentage: 76
                                Battery: /sys/class/power_supply/ doesn't contain any battery folder
                                Media Player: No media player found
                                Song: No song detected
                                Public IP: XXX.XXX.XXX.25
                                Local IP (enp5s0): 192.168.1.7
                                Date & Time: year: 2022; yearShort: 22; month: 7; monthPretty: 07; monthName: July; monthNameShort: Jul; weekNumber: 29; weekday: Wednesday; weekdayShort: Wed; dayInYear: 201; dayInMonth: 20; dayInWeek: 3; hour: 12; hourPretty: 12; hour12: 0; hour12Pretty: 12; minute: 13; minutePretty: 13; second: 22; secondPretty: 22
                                Locale: en_US.UTF-8
                                Vulkan: driver: radv [Mesa 22.1.3]; Api Version: 1.3.211; Conformance Version: 1.3
                                OpenGL: version: 4.6 (Compatibility Profile) Mesa 22.1.3; renderer: AMD Radeon RX 6800 XT (sienna_cichlid, LLVM 14.0.6, DRM 3.46, 5.18.12-3-MANJARO); vendor: AMD
                                OpenCL: version: OpenCL 1.1 Mesa 22.1.3; device: AMD Radeon RX 6800 XT (sienna_cichlid, LLVM 14.0.6, DRM 3.46, 5.18.12-3-MANJARO); vendor: AMD

                                ████████████████████████
                                ████████████████████████

Output of fastfetch --list-features:

libpci
vulkan
wayland
xcb-randr
xcb
xrandr
x11
gio
dconf
dbus
imagemagick7
chafa
zlib
xfconf
egl
glx
osmesa
opencl
LinusDierheimer commented 2 years ago

Fastfetch parses the following files in order, with version being one of 2, 3 and 4 looking for gtk-icon-theme-name =:

Where <configdir> is one of the following (if no XDG env variables overwrite it) in order:

So for gtk 4, the first file parsed will be ~/.config/gtk-4.0/settings.ini.

Can you please look if one of those files exist, and if yes, contain the wrong value?

DarNCelsius commented 2 years ago

Both ~/.config/gtk-4.0/settings.ini and ~/.config/gtk-3.0/settings.ini have the values as reported by Fastfetch:

gtk-font-name=DejaVu Sans,  9
gtk-icon-theme-name=Papirus-Dark

These values do not reflect the actual settings in use. This is the same as #199 then.

Neofetch:

██████████████████  ████████   darn@manjaro 
██████████████████  ████████   ------------ 
██████████████████  ████████   OS: Manjaro Linux x86_64 
██████████████████  ████████   Model: X570 AORUS MASTER -CF 
████████            ████████   Kernel: 5.18.12-3-MANJARO 
████████  ████████  ████████   Uptime: 16 hours, 43 mins 
████████  ████████  ████████   Packages: 1738 (pacman), 4 (flatpak) 
████████  ████████  ████████   Shell: zsh 5.9 
████████  ████████  ████████   Resolution: 2560x1440, 2560x1440, 2560x1440 
████████  ████████  ████████   DE: Cinnamon 5.4.3 
████████  ████████  ████████   WM: Mutter 
████████  ████████  ████████   WM Theme: Arc-Dark 
████████  ████████  ████████   Theme: Matcha-dark-azul [GTK2/3] 
████████  ████████  ████████   Icons: Qogir-dark [GTK2/3] 
                               Terminal: tilix 
                               CPU: AMD Ryzen 7 3800X (16) @ 4.560GHz 
                               GPU: AMD ATI Radeon RX 6800/6800 XT / 6900 XT 
                               Memory: 8277MiB / 15919MiB 
LinusDierheimer commented 2 years ago

Do you know where the settings app saves those settings, if it isn't this file? Some dconf / gsettings path probably.

BTW according to the arch wiki the file would be the correct location...

LinusDierheimer commented 2 years ago

Please try latest commit, at least Cinnamon should be working now.

DarNCelsius commented 2 years ago

Cinnamon works fine now. XFCE and LXQT does not.

LinusDierheimer commented 2 years ago

XFCE should have been working the whole time. What is the output of:

xfconf-query -c "xsettings" -p "/Net/IconThemeName"
xfconf-query -c "xsettings" -p "/Gtk/FontName"
DarNCelsius commented 2 years ago

xfcebug

LinusDierheimer commented 2 years ago

Fixed it for XFCE. Really silly error.

Now only LXQT is left. Do you know where it does store its configuration?

DarNCelsius commented 2 years ago

~/.config/lxqt/lxqt.conf:

[General]
__theme_updated__=1620329891003
__userfile__=true
icon_follow_color_scheme=true
icon_theme=Qogir-dark
single_click_activate=true
theme=system
tool_button_style=ToolButtonTextBesideIcon

[Palette]
base_color=#22252c
highlight_color=#2097d9
highlighted_text_color=#ffffff
link_color=#55aaff
link_visited_color=#ff00ff
text_color=#ffffff
window_color=#14161b
window_text_color=#dbdbdb

[Qt]
cursorFlashTime=1000
doubleClickInterval=400
font="DejaVu Sans,10,-1,5,50,0,0,0,0,0"
style=kvantum-dark
wheelScrollLines=1
LinusDierheimer commented 2 years ago

Is that really the GTK theme? Seems more like QT. Maybe it is more accurate to display a [QT] section, instead of GTK on LXQT?

LinusDierheimer commented 2 years ago

After some time of googling, LXQT really seem to use the GTK settings from the files, so fastfetch already displays that correct. It does use QT for its apps though, and theme info for that doesn't get loaded yet. I am still deciding if i should replace with [Plasma] with [QT] and use it for LXQT too, or if i create a [LXQT] section.

DarNCelsius commented 2 years ago

GTK/QT style is handled using kvantum here. Font and Icon theme should be toolkit independent. I don't know where it gets the defaults though.

DarNCelsius commented 2 years ago

Here are my LXQT settings and fastfetch output. As you can see, the Icon and font output shows the wrong info here too. lxqticontheme lxqtstyle lxqtfont lxqtff

LinusDierheimer commented 2 years ago

kavantum is a pure QT theme. I am also pretty sure that GTK doesn't parse ~/.config/lxqt/lxqt.conf, because the font is saved as an internal QT representation. If your setting app sets the GTK theme, it must be saved somewhere else. The screenshots you posted are all QT.

DarNCelsius commented 2 years ago

If you look at the bottom left of the app, there is a "GTK Style" category, which will modify .gtkrc-2.0 and .gtkrc-3.0 directly. lxqtgtk

DarNCelsius commented 2 years ago

Here's the Kvantum blurb:

To be able to choose the theme Qt applications are using on your Linux system, tweak some settings, and have an overall better integration with Gnome / Gtk, you can give [Kvantum](https://github.com/tsujan/Kvantum/tree/master/Kvantum) a try. This is a SVG-based theme engine for both Qt4 and Qt5, KDE and LXQt.

This is what I mean by GTK/QT. :)

LinusDierheimer commented 2 years ago

So that means, that on LXQT, ~/.gtkrc-3.0 is prefered over ~/.config/gtk-3.0/settings.ini?

And please try the latest patch, you should be seeing qt theme now.

LinusDierheimer commented 2 years ago

This is what I mean by GTK/QT. :)

This just means that you can achieve a QT look using Kvantum, that looks the same like GTK. Kvantum itself is purely QT.

DarNCelsius commented 2 years ago

Yes, I know, just clarifying.

~/.gtkrc-3.0 was a typo - I meant to write ~/.config/gtk-3.0/settings.ini.

LinusDierheimer commented 2 years ago

But if ~/.config/gtk-3.0/settings.ini already contains the correct GTK config, it should already be displayed correctly. With the latest patch you should also see the QT config.

DarNCelsius commented 2 years ago

It may contain the right GTK config, but not for Icon and font info for XFCE, Cinnamon and LXQT, which is why I made this issue.

Here's the new output: ffqt

LinusDierheimer commented 2 years ago

So the current behaviour is the correct one?

DarNCelsius commented 2 years ago

It think so. The QT info has the correct values for LXQT. Cinnamon and XFCE pulls info from the right sources. :+1:

It's a little odd seeing GTK2/3/4 values that I don't use anywhere though.