search

fastfetch-cli / fastfetch

An actively maintained, feature-rich and performance oriented, neofetch like system information tool.
MIT License
8.44k stars 350 forks source link

one case wrong info about terminal/shell #488

Closed Zeroes1 closed 1 year ago

Zeroes1 commented 1 year ago

may be can fix one case wrong info about terminal/shell ?

General description of bug:

I make some test flashfetch.exe 1.12.1.0 under win 10:

far under cmd Terminal: Console Window Host 10.0.19041.3031 Shell: Far

Terminal: WezTerm 20230622-212134-f21dcb96 Shell: Command Prompt 10.0.19041.746

Terminal: Windows Terminal 1.18.2305.26002 Shell: Far

under conemu Terminal: ConEmu 221218 Shell: PowerShell 7.3.5

Terminal: ConEmu 221218 Shell: Windows PowerShell 5.1.19041.3031

Terminal: ConEmu 221218 Shell: Command Prompt 10.0.19041.746

image but last test is WRONG? (under ConEmu I run FAR): Terminal: Far 3.0.6171.0 Shell: ConEmuC64

need show like: Terminal: ConEmu 221218 Shell: Far 3.0.6171.0

reproduced 100%

Zeroes1 commented 1 year ago

Hmm this effect only if turn ON ConEmu option: [x] Inject ConEmuHk.dll into all processes started in ConEmu tabs

if turn off this option, flashfetch show right info : Terminal: ConEmu 221218 Shell: Far

CarterLi commented 1 year ago
image

For some reason, Far calls ConEmuC64 to run fastfetch. Will fix it.

CarterLi commented 1 year ago

Please test it with the newest CI build

Zeroes1 commented 1 year ago

now, good! thnx! :)