fastfetch-cli / fastfetch

A maintained, feature-rich and performance oriented, neofetch like system information tool.
MIT License
10.78k stars 416 forks source link

Mutter WM theme wrong on Budgie #56

Closed DarNCelsius closed 3 years ago

DarNCelsius commented 3 years ago

On Budgie desktop, the Mutter WM Theme is wrong. There's nothing using Arc-Dark on my system. budgiewmtheme Dconf editor shows the key used as being deprecated. The theme being used is Matcha-Dark-Azul.

DarNCelsius commented 3 years ago

Here's a comment from the Budgie dev on Mutter themes: https://github.com/dylanaraps/neofetch/issues/408#issuecomment-258986472 So WM Theme is basically the same as GTK theme, or nothing at all.

LinusDierheimer commented 3 years ago

Should work with latest commit. Close this on confirm.

DarNCelsius commented 3 years ago

Looks good :+1:

DarNCelsius commented 3 years ago

You should probably still rewrite printMutter(). "/org/gnome/desktop/wm/preferences/theme" is not in use, and I think "/org/gnome/shell/extensions/user-theme/name" is only there with certain extensions. It certainly didn't exist when I tried Gnome. I think it's just GTK in that case.

LinusDierheimer commented 3 years ago

I copied this directly from neofetch:

wm_theme=$(gsettings get org.gnome.shell.extensions.user-theme name)
[[ ${wm_theme//\'} ]] || \
    wm_theme=$(gsettings get org.gnome.desktop.wm.preferences theme)

There is an official extension "user theme" which allows custom theming of the shell, so we check that first. Maybe we should fallback to GTK if both of them fail.

DarNCelsius commented 3 years ago

I think so - that's the Gnome default. You'd have to be running a very old install if "org.gnome.desktop.wm.preferences theme" works though.