fastfloat / fast_float

Fast and exact implementation of the C++ from_chars functions for number types: 4x to 10x faster than strtod, part of GCC 12, Chromium and WebKit/Safari
Apache License 2.0
1.35k stars 124 forks source link

Function `write_u64` seems to be unused #244

Closed matthew-wozniczka closed 5 months ago

matthew-wozniczka commented 5 months ago

https://github.com/fastfloat/fast_float/blob/7c19cafa93181c9848b5f4b9e05d0a117cafc2c6/include/fast_float/ascii_number.h#L128

It's only come to my attention because I'm looking forward to MS complaining about the use of memcpy, and that's the only place in this library where it's not obviously clear that it's not overflowing a buffer (even given the name...). Removing it could avoid future hassles.