Closed zejal closed 3 months ago
@zejal Can you motivate this change? Why is it beneficial?
This would allow someone (as I would like to do to use fast_float in existing code) to write an alternative string parser function that creates and populates the parsed_number_string_t and call added overloaded function. Of course the existing from_chars_advanced taking chars range and parsing options remains and called suggested added one.
Perhaps accepting this change implies to document a bit what the contents of parsed_number_string_t structure. In particular the integer and fraction bits ?
Perhaps accepting this change implies to document a bit what the contents of parsed_number_string_t structure. In particular the integer and fraction bits ?
Do you want to add some comments to the code so that this is clearer? No need to write very much, just enough so that people understand why the code is structured this way.
Thanks, added some comments, hope it helps.
I expect to merge once the test pass.
It should be part of the next release.
Sure, thanks a lot
Idea is to split parsing from value computation adding a from_chars_advanced function taking result of parsing.