search

fastfloat / fast_float

Fast and exact implementation of the C++ from_chars functions for number types: 4x to 10x faster than strtod, part of GCC 12, Chromium and WebKit/Safari
Apache License 2.0
1.35k stars 123 forks source link

Build warning on Clang with -Wdeprecated-redundant-constexpr-static-def #254

Open stephenberry opened 1 month ago

stephenberry commented 1 month ago

out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated

Enabling -Wdeprecated-redundant-constexpr-static-def with warnings as errors causes fast_float to not build on Clang.

Fixing this should make the code cleaner as well.

lemire commented 1 month ago

@stephenberry pull request invited!

stephenberry commented 1 month ago

I think to support C++11 you would need macros around the old expressions. Do you want this?

lemire commented 1 month ago

The library is C++11 and we do not want to change this.

Using macros is acceptable.