@tinyhttp/app Missing from dependencies causes benchmark to fail - Githubissues

fastify / benchmarks

Fast and low overhead web framework fastify benchmarks.

https://github.com/fastify/fastify

MIT License

599 stars 231 forks source link

@tinyhttp/app Missing from dependencies causes benchmark to fail #313

Closed nrayburn-tech closed 1 year ago

nrayburn-tech commented 1 year ago

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the bug has not already been reported

Fastify version

4.10.2

Plugin version

No response

Node.js version

18.15.0

Operating system

macOS

Operating system version (i.e. 20.04, 11.3, 10)

14.0 (23A344)

Description

https://github.com/fastify/benchmarks/pull/304 didn't add @tinyhttp/app to the dependencies, so when trying to run the benchmarks it fails due to the missing package.

CI failure https://github.com/fastify/benchmarks/actions/runs/6686926348/job/18166915878

Steps to Reproduce

npm install && npm run start

Expected Behavior

Benchmarks run without failing.