fastify / fast-json-stringify

2x faster than JSON.stringify()
MIT License
3.51k stars 208 forks source link

TypeCoercion like ajv #607

Open Uzlopak opened 1 year ago

Uzlopak commented 1 year ago

Prerequisites

Issue

In my opinion, we should do the same type coercion like ajv does.

https://ajv.js.org/coercion.html

jsumners commented 1 year ago

To what end? AJV is coercing JSON into JavaScript natives. FJS is converting JavaScript natives into JSON.

Uzlopak commented 1 year ago
const fastJson = require('fast-json-stringify')

const stringify = fastJson({
  title: 'Example Schema',
  type: 'object',
  properties: {
    boolean: {
      type: 'boolean'
    }
    }
})

console.log(stringify({
    boolean: "false"
}))

results in "{\"boolean\":true}"

awesome

ivan-tymoshenko commented 1 year ago

Not a good example IMHO. With the same result, you can complain about the js standard. !!"false" === true

but I also don't like some types coercions that we have. The question is what should we do in this case?

Uzlopak commented 1 year ago

The risk that I see here is about diverging behaviour between ajv and fsj. Then we have some cases were ajv validates as valid and fsj maybe throws or serializes it differently. Also we potentially need to coerce the vaues if we want to process them for stuff like const and enum. If we want to go that way.

Eomm commented 1 year ago

I'm pro to good coercion default and not throwing.