types: improve typing to allow custom request and reply

fastify / fastify-auth

Run multiple auth functions in Fastify

Other

341 stars 56 forks source link

types: improve typing to allow custom request and reply #211

Closed Puppo closed 6 months ago

Puppo commented 7 months ago

This PR closes #207

Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

hershmire commented 7 months ago

@Puppo thanks for the PR!

@mcollina @Uzlopak any resolution on this?

Puppo commented 7 months ago

@Uzlopak any news on this one? otherwise Matteo cannot merge the PR.

Uzlopak commented 7 months ago

@fastify/typescript

Can somebody else have a look at it. I dont want to be a blocker, but I dont think that the arguments are valid as the generic types are not passed down to the FastifyReply and FastifyRequest.

climba03003 commented 7 months ago

I dont think that the arguments are valid as the generic types are not passed down to the FastifyReply and FastifyRequest.

That is true, but most of the time people use only the default server then it would be fine. It worth a trial how it impact.

Uzlopak commented 7 months ago

@mcollina

Somebody has to decide if this gets merged and published or not.