fastify / fastify-cli

Run a Fastify application with one command!
MIT License
644 stars 160 forks source link

fix: make-promises-safe is no longer required #711

Closed 10xLaCroixDrinker closed 4 months ago

10xLaCroixDrinker commented 4 months ago

make-promises-safe is not required in Node.js 15+. I presumed this would be non-breaking for fastify-cli because the test matrix is only 18, 20 & 21. I left in the tests that were added when make-promises-safe was added, and they continue to pass locally on Node.js 20 & 21. I have an issue with the tests in master hanging in Node 18, so couldn't confirm that certainly but there weren't any failures before the hang.

Checklist