Fix/incorrect vary header

fastify / fastify-compress

Fastify compression utils

MIT License

199 stars 46 forks source link

Closed stanleyxu2005 closed 5 months ago

stanleyxu2005 commented 5 months ago

The PR is about to fix a bug reported by #279 The PR will set response header vary only when compression actually happened

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

stanleyxu2005 commented 5 months ago

Is there a test that will fail without this change?

Yes. I see roughly ~40 test cases failing before moving setVaryHeader around in my 2nd commit of the PR.