Are react-refresh issues solved? - Githubissues

fastify / fastify-dx

Archived

900 stars 42 forks source link

Are react-refresh issues solved? #50

Open IanVS opened 2 years ago

IanVS commented 2 years ago

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the issue has not already been raised

Issue

Hi, I found a note in https://github.com/fastify/fastify-dx/blob/f40758a4ef71296aded52dd88a08287a4824915c/starters/react/vite.config.js#L14 about a vite bug with react fast-refresh breaking context changes. This should be fixed in the latest versions of the vite react plugin. Would you be wiling to try it out and check? (I'm not using this package, just poking around and I worked on the PR that fixed that bug).

galvez commented 2 years ago

New release for React adapter is literally almost out the door — I'll follow up on this issue then.