Fix onRequest hook documentation

fastify / fastify-jwt

JWT utils for Fastify

MIT License

512 stars 99 forks source link

Closed mattiapv closed 1 year ago

mattiapv commented 1 year ago

Added missing async and await keywords, try...catch block. This prevents server crashes caused by missing await on jwtVerify() function.

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

mattiapv commented 1 year ago

None of this are needed, why did you add them?

Because without awaiting jwtVerify() the server crash.

You can try the cookie or the onlyCookie example.

If you make a call to http://localhost:3000/verifyCookie the server crash.

If I add await request.jwtVerify(), I receive the correct error (FST_JWT_NO_AUTHORIZATION_IN_HEADER) and the server doesn't crash.