Partly closes #496: add missing type

fastify / fastify-multipart

Multipart support for Fastify

MIT License

479 stars 103 forks source link

Partly closes #496: add missing type #502

Closed hash0000 closed 9 months ago

hash0000 commented 9 months ago

Fix type missing. More info in issue #496.

Checklist

[x] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

mcollina commented 9 months ago

The type test is https://github.com/fastify/fastify-multipart/blob/master/types/index.test-d.ts

hash0000 commented 9 months ago

Do the files() and file() support all options from the FastifyMultipartBaseOptions interface (except throwFileSizeLimit and limits, of course)?

mcollina commented 9 months ago

I think so, but verify with the code.

hash0000 commented 9 months ago

I'm not sure, but did you mean this test?

Uzlopak commented 9 months ago

Lets run the tests. Your holistic approach to also test the same thing in javascript is apprecaited.