handle @fastify/x names to export

Uzlopak commented 2 years ago

Checklist

[x] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

Uzlopak commented 2 years ago

Before we had e.g. fastify-kafka as module name which was automatically changed to the named export fastifyKafka So it was basically generating module.exports.fastifyKafka = plugin

We renamed all fastify own modules to the form @fastify/x-y-z. So now the named exports are '@fastify/xYZ' which is equivalent to module.exports['@fastify/xYZ'] = plugin.

If the current behaviour is correct, than we have to rewrite the failing test in https://github.com/fastify/fastify-kafka/pull/69 accordingly. If not, we have to merge this, and then the test in that PR will pass.

Uzlopak commented 2 years ago

@zekth you want to review again? @jsumners do you have further questions?

fastify / fastify-plugin

handle @fastify/x names to export #190

Checklist