fix: migrate from tap to node test and c8

fastify / fastify-plugin

Plugin helper for Fastify

MIT License

202 stars 43 forks source link

fix: migrate from tap to node test and c8 #248

Closed nimesh0505 closed 1 month ago

nimesh0505 commented 1 month ago

Checklist

This PR replaces tap with node:test for testing and adds c8 for coverage.

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

Uzlopak commented 1 month ago

I agree with @jsumners . It doesnt make any sesnse and has no benefit of making functions async if there is nothing to be awaited etc.. So yes, please remove unnecesasry async.

simoneb commented 1 month ago

comments addressed