search

fastify / fastify-rate-limit

A low overhead rate limiter for your routes
MIT License
480 stars 67 forks source link

Retry-After should use units of seconds #311

Closed Forty-Bot closed 1 year ago

Forty-Bot commented 1 year ago

Description

The Retry-After header uses units of milliseconds.

Steps to Reproduce

Make enough requests to be rate-limited and observe that Retry-After has incorrect semantics.

Expected Behavior

The Retry-After header should use units of seconds.

c43721 commented 1 year ago

https://github.com/fastify/fastify-rate-limit/tree/master#ietf-draft-spec-headers

Looks like this is configurable, but shouldn't this be the default?

Uzlopak commented 1 year ago

This was alread fixed in #307