fastify / fastify-rate-limit

A low overhead rate limiter for your routes
MIT License
477 stars 66 forks source link

chore(package): explicitly declare js module type #332

Closed Fdawgs closed 10 months ago

Fdawgs commented 10 months ago

Node 21.1.0 added a flag to detect module types, which will probably become default in the future. Declaring the type will cause Node to skip detection on startup, reducing startup time.

Declaring the package type is also considered good practice according to https://nodejs.org/api/modules.html#enabling anyway, and the main fastify repo already does it.

Will update the rest of the repos and point to this PR in their PRs.

Checklist

Fdawgs commented 10 months ago

Not too sure on repos like https://github.com/fastify/fastify-flash that are written in TS but compile to CJS

simoneb commented 10 months ago

To be honest I don't think this will ever happen, as it would break existing applications. I would find it more likely that from a major version onwards, it will default it to module instead of cjs.