fastify / fastify-rate-limit

A low overhead rate limiter for your routes
MIT License
504 stars 71 forks source link

Reach 100% test coverage #371

Closed gurgunday closed 4 months ago

gurgunday commented 4 months ago

Prerequisites

Issue

We want to remove:

https://github.com/fastify/fastify-rate-limit/blob/595a627020837d5c4ad3de7a235f385f3e6af2a5/.taprc#L3-L6

jean-michelet commented 4 months ago

I have a lot of failures locally: Ubuntu 22, Node 22

summary

gurgunday commented 4 months ago

It's because you need a running redis instance on your machine

https://github.com/fastify/fastify-rate-limit/blob/595a627020837d5c4ad3de7a235f385f3e6af2a5/.github/workflows/ci.yml#L18

You can use Docker to set one up, or use Actions/CI on your local repo to test the changes