feat: dragonfly decorator

fastify / fastify-redis

Plugin to share a common Redis connection across Fastify.

MIT License

198 stars 31 forks source link

feat: dragonfly decorator #185

Closed ilteoood closed 1 year ago

ilteoood commented 1 year ago

Resolves #184

Checklist

[X] run npm run test and npm run benchmark
[X] tests and/or benchmarks are included
[X] documentation is changed or added
[X] commit message and code follows the Developer's Certification of Origin and the Code of conduct

ilteoood commented 1 year ago

Hi @mcollina, You are right: the purpose of this is just to define a different decorator name if the user wants to use this plugin with Dragonfly instead of Redis. My idea behind this is just to improve the DX and avoid the user to type fastify.redis when he's not using Redis, but Dragonfly.

kibertoad commented 1 year ago

@ilteoood This seems to complicate the codebase for questionable benefits. I'm -1 on it.

ilteoood commented 1 year ago

Ok then, at least I tried. Thank you everyone for your time, feel free to close both the PR and the issue then