szegheo
commented
8 months ago OK, finally I figured out, that it occurs when the client request arrives with Connection: keep-alive (default on HTTP/1.1 requests). Run the code below and wait ~3 sec:
const Fastify = require('fastify')
const fastifyHttpProxy = require('@fastify/http-proxy')
// PROXY TARGET
const fastifyProxyTarget = Fastify({
logger: { level: 'debug' },
disableRequestLogging: false,
}).put('/api', async (request, reply) => reply.code(204).send())
// CLIENT REQUESTS RECEIVER
const fastify = Fastify({
logger: { level: 'debug' },
disableRequestLogging: false,
});
fastify.register(fastifyHttpProxy, {
upstream: 'http://localhost:3000/',
prefix: '/proxytest',
http2: false,
http: {
requestOptions: {
timeout: 2000 //2sec
}
}
});
async function startTest() {
await fastifyProxyTarget.listen({ port: 3000 });
await fastify.listen({ port: 5000 });
await fetch('http://localhost:5000/proxytest/api', {
method: 'PUT',
headers: {
// 'Connection': 'close' // OK
'Connection': 'keep-alive' // response errored
}
});
}
startTest()The above code triggers the "response errored" warning with (current) v4.25.1, but not with 4.23.2
Eomm
Prerequisites
Last working version
4.23.2
Stopped working in version
4.24.0
Node.js version
18
Operating system
Linux
Operating system version (i.e. 20.04, 11.3, 10)
Ubuntu 22.04.3 LTS
💥 Regression Report
In our Fastify server we forward all the API requests from the frontend to another micro-service with a global proxy handler routine. We have only one PUT endpoint, and starting from Fastify v4.24.0, every call to this PUT (204) endpoint raises a false "response errored" warning log. However, this proxied PUT request is processed fine on the target, and examining the Fastify logs it shows that everything went normal, except the last line here:
All the other GETs and POSTs are working fine with the same
preHandlerlogic, where we basically just decode a cookie and set an Authorization header:I've spent a lot of time on this issue, but still don't know why it happens. On our side I see no reason, and it was fine with versions prior to 4.24.0 (so we've been reverted to 4.23.2). I've double checked that PUT endpoint, there's no response body and the response headers are fine (no content-length). Calling it directly from Postman also runs fine. I've tried to remove all our hooks and as much code as possible, but the warning is always there.
I'm trying to create a reproduction code (no luck as of now), but meanwhile I would kindly ask you to take a look on this. Maybe the changes made to the affected Fastify version will show you some connection. My suspect is this change. What do you think?
Thanks in advance!
Steps to Reproduce
I'm working on it... Unfortunately, my first attempts didn't triggered the issue.Please see my post below.Expected Behavior
No "response errored" warns for PUT responses with code 204. As it was before 4.24.0.