search

fastify / fastify-reply-from

fastify plugin to forward the current http request to another server
MIT License
148 stars 76 forks source link

build(deps): Bump undici from 5.28.3 to 6.10.1 #356

Closed dependabot[bot] closed 5 months ago

dependabot[bot] commented 5 months ago

Bumps undici from 5.28.3 to 6.10.1.

Release notes

Sourced from undici's releases.

v6.10.0

What's Changed

New Contributors

Full Changelog: https://github.com/nodejs/undici/compare/v6.9.0...v6.10.0

v6.9.0

What's Changed

New Contributors

Full Changelog: https://github.com/nodejs/undici/compare/v6.8.0...v6.9.0

v6.8.0

What's Changed

New Contributors

Full Changelog: https://github.com/nodejs/undici/compare/v6.7.1...v6.8.0

v6.7.1

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
elmarcusec commented 5 months ago

@simoneb @mcollina @airhorns @trygve-lie I have a question - when do you plan to merge this change? I would like to continue using your library, but I also need undici to be in a higher version :)

simoneb commented 5 months ago

@elmarcusec CI seems to be broken, we can't merge until it's green. I'll try to trigger another run to see what happens.

simoneb commented 5 months ago

@dependabot rebase

dependabot[bot] commented 5 months ago

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

simoneb commented 5 months ago

ok so the PR was already up to date with master, and the problem is that the code needs to change to reflect that changes made in undici. @elmarcusec if you need this, would you be interested in looking into this and make the necessary changes? I haven't assessed the extent of such changes yet, but they're hopefully not major. You can start by looking into the failing tests https://github.com/fastify/fastify-reply-from/actions/runs/8422259328/job/23061145566?pr=356

gurgunday commented 5 months ago

We can't include this in this cycle as undici no longer supports node versions <16

mcollina commented 5 months ago

I'm planning to bump a major with this soon.

dependabot[bot] commented 5 months ago

A newer version of undici exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

elmarcusec commented 5 months ago

@mcollina I just wanted to ask about when you plan to merge it, because I have to answer in the project when it will be solved

gurgunday commented 5 months ago

@mcollina if you want to release it as well, we can just update the workflow in next to v4.1.0 and release, but node 14 support will end

gurgunday commented 5 months ago

See https://github.com/fastify/fastify-reply-from/pull/359

dependabot[bot] commented 5 months ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.