Closed voxpelli closed 1 year ago
Test is missing
One question on this: In which of the three test files should tests preferably be added?
There seems to be e2e tests that's run in both jest and tap? + non-e2e tests in jest?
@voxpelli e2e is preferable
@kibertoad Should it be added in both the jest and tap ones then? I see that tap tests were added in #50 since jest tests were failing, now they all pass for me locally at least
@voxpelli yeah, jest problem was fixed later. either of them or both would be good, I would err on the side of more jest tests
@kibertoad Tests added
Thank you!
This PR fixes #156 by adding the current request instance as a parameter to the
defaultStoreValues()
factoryChecklist
npm run test
and(does not exist on this project)npm run benchmark