fix generate-key as binary

fastify / fastify-secure-session

Create a secure stateless cookie session for Fastify

MIT License

204 stars 47 forks source link

fix generate-key as binary #154

Closed Uzlopak closed 2 years ago

Uzlopak commented 2 years ago

Resolves #134

Checklist

[x] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

mcollina commented 2 years ago

Let's create a separate package. Unfortunately we can't rely on node_modules being there.

Uzlopak commented 2 years ago

@mcollina @climba03003

This is my proposal to solve the issue. As long yarn and npx does not support '/ as bin operations we could do this. When they someday implemented it on their end, we could implement it without an additional package.

climba03003 commented 2 years ago

This is my proposal to solve the issue. As long yarn and npx does not support '/ as bin operations we could do this. When they someday implemented it on their end, we could implement it without an additional package.

The problem comes from yarn only, not npx. When ever it use yarn to install the package, it fail to link the bin.