replace instanceof Array and instanceof Buffer with Array.isArray and Buffer.isBuffer

fastify / fastify-secure-session

Create a secure stateless cookie session for Fastify

MIT License

204 stars 47 forks source link

replace instanceof Array and instanceof Buffer with Array.isArray and Buffer.isBuffer #158

Closed Uzlopak closed 2 years ago

Uzlopak commented 2 years ago

replace instanceof Array and instanceof Buffer with Array.isArray and Buffer.isBuffer

I dont know which one we prefer in fastify. Would be imho good if we had some styleguide

Checklist

[x] run npm run test and npm run benchmark
[ ] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

Uzlopak commented 2 years ago

Style

Uzlopak commented 2 years ago

what about Array.isArray?

mcollina commented 2 years ago

I don't see the point in changing this for no specific value. I don't see how one is more readable than others, and I don't want to establish any pattern or rule across the org.

Uzlopak commented 2 years ago

fair enough