test: deflake tests - Githubissues

fastify / fastify-swagger-ui

Serve Swagger-UI for Fastify

MIT License

125 stars 38 forks source link

test: deflake tests #113

Closed Uzlopak closed 7 months ago

Uzlopak commented 7 months ago

Closes #110 I guess we should have awaited some of the .register() calls and make it more robust.

Checklist

[x] run npm run test and npm run benchmark
[x] tests and/or benchmarks are included
[ ] documentation is changed or added
[x] commit message and code follows the Developer's Certification of Origin and the Code of conduct

Uzlopak commented 7 months ago

I ran the CI twice now and no tests failed.

Uzlopak commented 7 months ago

@mcollina PTAL

;)

mcollina commented 7 months ago

disabling code coverage would make the test pass, there is a bug in node

Uzlopak commented 7 months ago

@mcollina

Well, i dont know anymore. I tried to improve the code at best to avoid any race conditions or whatever. I quite dont get why it fails. But if you are ok, i would like to merge.