fastify / fastify-swagger-ui

Serve Swagger-UI for Fastify
MIT License
125 stars 38 forks source link

Update tap version to avoid intermittent test failures. #115

Closed DavidTanner closed 5 months ago

DavidTanner commented 6 months ago

Checklist

Even after #113 was closed, I can still get random errors in route.test.js. I have tested it over and over, and believe it is caused by the internals of Tap when collecting coverage. To test the theory I updated tap, and relevant tests, and can no longer repro the timeout.

I tested using a simple script that called npx tap repeatedly until a failure occurred.

gurgunday commented 6 months ago

Should there be a next branch?

The workflow change will stop testing for node v14

mcollina commented 6 months ago

I'm actually ok to ship a major. There aren't many issues with modules like this one.

mcollina commented 6 months ago

(to land as BlueOak is OSI-approved).

DavidTanner commented 5 months ago

@Uzlopak the license has been approved, can this PR be merged now?