Closed thorhj closed 1 year ago
Two considerations for the reviewer:
swaggerTransform
but supports both OpenAPI and Swagger specs of course. Don't know if that is confusion and a better name should be added (or two separate properties).swaggerTransform
to be given the value null
which has its own specific meaning. Maybe this should be the string literal "disable"
or something else to be more clear.missing typing tests.
Added some tests in types.test.ts
. Let me know if they should be written differently, haven't made such tests before (I'm usually working in Typescript directly 😉)
I reviewed it now.
swggerTransform null is quiet unintuitive. I would personally prefer false for deactivating.
I agree, changed it to false
instead of null
.
When is this set to be released? 🤔
done now
Addressing #749
Checklist
npm run test
andnpm run benchmark