fastify / fastify-throttle

Throttle the download speed of a request
Other
18 stars 5 forks source link

initial implementation #1

Closed Uzlopak closed 1 year ago

Uzlopak commented 1 year ago

Checklist

Uzlopak commented 1 year ago

@metcoder95

It was https://github.com/fastify/fastify-rate-limit/issues/290

I found it kind of challenging. Also tbh. there was no simple implementation of throttle stream. All of them on npm are kind of overcomplicated solutions.

I am currently investigating how we can have a way to implement it on multiple instances with a redis store or something like this. First lets get this implemented and then adapt it for multi service.

a-a-GiTHuB-a-a commented 1 year ago

How would a test for this plugin even work?

Uzlopak commented 1 year ago

@a-a-GiTHuB-a-a What you mean?

a-a-GiTHuB-a-a commented 1 year ago

How would we test to make sure the package throttles requests properly?

Uzlopak commented 1 year ago

Ok, well I merge this, and hope somebody releases it. (Looking at @Eomm )

Lets see when the first people complain, that the throttling does not work and it is total garbage LOL