refactor: update types

[climba03003]

Closes #70 Closes #71 Fixes #68

Checklist

• [ ] run npm run test and npm run benchmark
• [ ] tests and/or benchmarks are included
• [ ] documentation is changed or added
• [ ] commit message and code follows the Developer's Certification of Origin and the Code of conduct

[climba03003]

It somehow working on my side. Keep all packages the latest always the key in TypeScript world.

[climba03003]

Interesting, it error only when using tsc but not the runtime.

The problem is non-strict mode.

[mcollina]

The problem is non-strict mode.

Confirmed.

Even with this change, tsserver still complains on my machine.

[climba03003]

Even with this change, tsserver still complains on my machine.

The same error? Maybe try it from fresh.

git clone https://github.com/fastify/fastify-type-provider-json-schema-to-ts.git
cd fastify-type-provider-json-schema-to-ts
git checkout update
npm install
npm run build
npm run typescript

[mcollina]

[mcollina]

The compilation still fail without --strict as well.

[jfet97]

The strictNullChecks flag seems to be enough: npx tsc --strictNullChecks --noEmit types/*.ts doesn't emit any error.

Probably the library you are using relies on having null and undefined as distinct types while checking some base case for some recursive computation.

If strictNullChecks is false, null and undefined are assignable to all types, therefore any extends check could change behaviour if the checked type is null or undefined.

[jfet97]

The documentation of json-schema-to-ts says exactly that strict: true is required

[Uzlopak]

@jfet97 Good point. If that is so, we should document it also in this repo.