fastify / fastify-type-provider-json-schema-to-ts

A Type Provider for json-schema-to-ts
MIT License
35 stars 8 forks source link

feat: fastify 5 with separated type-providers #97

Closed Bram-dc closed 2 months ago

Bram-dc commented 2 months ago

Checklist

The tests will not work since this fastify 5 change has not been committed yet.

This is a patch to work correctly with https://github.com/fastify/fastify/pull/5427

Bram-dc commented 2 months ago

Do we need to add a message in the README that this only works for fastify >=5 ?

gurgunday commented 2 months ago

Do we need to add a message in the README that this only works for fastify >=5 ?

Targeting next is enough

gurgunday commented 2 months ago

Same as: https://github.com/fastify/fastify-type-provider-typebox/pull/153#issuecomment-2163027495

gurgunday commented 2 months ago

Please pull from the next branch

Bram-dc commented 2 months ago

Please pull from the next branch

Do you mean the github branch "next" instead of the npm tag "next"? Is there a difference?

gurgunday commented 2 months ago

Do you know why it’s failing? Maybe we need to release a more recent v5

Bram-dc commented 2 months ago

Fastify 5 with these changes has not been published to npm. The "next" tag references "5.0.0-aplha.1", which does not have these changes.

jsumners commented 2 months ago

Resolved by #100.